Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google.golang.org/api/idtoken: TestNewClient_WithCredentialFile failed #2522

Closed
flaky-bot bot opened this issue Apr 16, 2024 · 1 comment · Fixed by #2525
Closed

google.golang.org/api/idtoken: TestNewClient_WithCredentialFile failed #2522

flaky-bot bot opened this issue Apr 16, 2024 · 1 comment · Fixed by #2525
Assignees
@codyoss
Labels
flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 16, 2024

Note: #1833 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 4054271
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 16, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Apr 17, 2024

commit: f49960d
buildURL: Build Status, Sponge
status: failed

codyoss added a commit to codyoss/google-api-go-client that referenced this issue Apr 17, 2024
@codyoss
fix(internal): set scopes for new auth flow
60d5f14 
Also updated a test that relied on impl specific types before.
Testing the TokenSource methods instead of NewClient as NewClient
defers impl to NewTokenSource anyways.

Fixes: googleapis#2523
Fixes: googleapis#2522
@codyoss codyoss mentioned this issue Apr 17, 2024
Merged
codyoss added a commit that referenced this issue Apr 17, 2024
@codyoss
fix(internal): set scopes for new auth flow (#2525)
0f0a2f0 
Also updated a test that relied on impl specific types before.
Testing the TokenSource methods instead of NewClient as NewClient
defers impl to NewTokenSource anyways.

Fixes: #2523
Fixes: #2522
@release-please release-please bot mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(internal): set scopes for new auth flow codyoss/google-api-go-client
1 participant
@codyoss