Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idtoken: validator uses ADC when it should not #1682

Closed
codyoss opened this issue Aug 31, 2022 · 0 comments · Fixed by #1789
Closed

idtoken: validator uses ADC when it should not #1682

codyoss opened this issue Aug 31, 2022 · 0 comments · Fixed by #1789
Assignees
@codyoss
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@codyoss
Copy link
Member

codyoss commented Aug 31, 2022

Context: googleapis/google-cloud-go#6574

When using the constructor the validator unintentionally uses ADC since it uses client options to configure the client. I think the client should be default pass the no auth option perhaps.
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 31, 2022
@adrianajg adrianajg mentioned this issue Dec 27, 2022
Merged
codyoss pushed a commit that referenced this issue Jan 3, 2023
@adrianajg
fix(idtoken): configure validator constructor to use no authentication (
b35900a 
#1789)

Fixes: #1682
@release-please release-please bot mentioned this issue Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@codyoss