Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
codyoss committed Nov 14, 2024
1 parent 5a0946a commit cebc259
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions option/internaloption/internaloption.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ type EmbeddableAdapter struct{}

func (*EmbeddableAdapter) Apply(_ *internal.DialSettings) {}

// GetLogger is a helper for client libraries to extract the from the provided options
// or return a default logger if one is not found.
// GetLogger is a helper for client libraries to extract the [slog.Logger]from
// the provided options or return a default logger if one is not found.
//
// It should only be used internally by generated clients. This is an EXPERIMENTAL API
// and may be changed or removed in the future.
Expand Down
2 changes: 1 addition & 1 deletion option/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ func (w withUniverseDomain) Apply(o *internal.DialSettings) {
// WithLogger returns a ClientOption that sets the logger used throughout the
// client library call stack. If this option is provided it takes precedence
// over the value set in GOOGLE_SDK_GO_LOGGING_LEVEL. Specifying this option
// enables logging at the provided loggers configured level.
// enables logging at the provided logger's configured level.
func WithLogger(l *slog.Logger) ClientOption {
return withLogger{l}
}
Expand Down

0 comments on commit cebc259

Please sign in to comment.