Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use go get -u on this module with its current latest pseudo-version #151

Closed
dmitshur opened this issue Mar 14, 2019 · 7 comments
Closed
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@dmitshur
Copy link

dmitshur commented Mar 14, 2019

This module is currently affected by an issue similar to openzipkin/zipkin-go#114. It can be reproduced with Go 1.12 as follows:

$ export GO111MODULE=on
$ cd $(mktemp -d)
$ go mod init m
go: creating new go.mod: module m
$ go get -u google.golang.org/genproto
...
go: finding github.com/golang/lint latest
go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"
...
go get: error loading module requirements
$ echo $?
1

To resolve this for this repository, its go.mod file needs to be updated to include newer versions of dependencies, in order to avoid pulling in older module versions that cause this conflict.

I haven't looked into the exact cause for this repo yet. It might be just a matter of waiting for golang/go#30833 to be resolved. I'll investigate more later.

/cc @broady @bcmills

@jeanbza jeanbza added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Mar 14, 2019
@jeanbza jeanbza self-assigned this Mar 14, 2019
@jeanbza
Copy link
Contributor

jeanbza commented Mar 14, 2019

Seems to be an issue with how go modules interprets modules whose names have changed (github.com/x/lint and golang.org/x/lint). Tracking discussion in golang/go#30831.

@jeanbza jeanbza added type: process A process-related concern. May include testing, release, or the like. and removed status: investigating The issue is under investigation, which is determined to be non-trivial. labels Mar 14, 2019
@jeanbza
Copy link
Contributor

jeanbza commented Mar 14, 2019

Since this is a core issue and affects anyone depending on x/lint, I'm closing this in favour of golang/go#30831.

@jeanbza jeanbza closed this as completed Mar 14, 2019
@xomaczar
Copy link

@jadekler while we are waiting for a resoluton, do you mind updating your go.mod to point to the latest google.golang.org/[email protected].

@thepudds
Copy link

thepudds commented Apr 23, 2019

@xomaczar What specific error are you seeing, and what version of genproto are you using (e.g., via go list -m all), and what version of what dependency is giving you that version of genproto (e.g., via go mod graph | grep genproto)?

There has been progress in other related issues. See googleapis/google-api-go-client#342 (comment) for example. You might need to manually change one or more versions in your go.mod though in order to then get back to being able to do go get -u.

@thepudds
Copy link

@xomaczar Also, do the steps initially reported in #151 (comment) work for you, or do those exact steps listed there still give you a parsing go.mod: unexpected module path "golang.org/x/lint" error?

@jeanbza
Copy link
Contributor

jeanbza commented Apr 23, 2019

+1, I'd also like to know if there are specific issues related to grpc at the moment.

@xomaczar
Copy link

xomaczar commented Apr 23, 2019

@thepudds yes I can confirm the same error message mentioned by @dmitshur - however it was related to my internal module which was still using an old version of genproto. After bumping the version, all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants