fix: quarantine axios config #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 49 48 -1
Branches 9 12 +3
=====================================
- Hits 49 48 -1
Continue to review full report at Codecov.
|
|
@ofrobots @stephenplusplus bumpity bumble bump |
ofrobots
reviewed
Jul 11, 2018
There was a problem hiding this comment.
Looking good to me, and quarantining axios sounds like the right thing to do. It would be good if @stephenplusplus can take a look too.
README.md
Outdated
| const res = await gcpMetadata.instance('hostname'); | ||
| console.log(res.data) // ...All metadata properties | ||
| const data = await gcpMetadata.instance('hostname'); | ||
| console.log(data) // ...All metadata properties |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| pair.invalid}' is not a valid configuration option. Please use '${ | ||
| pair.expected}' instead. This library is using Axios for requests. Please see https://github.com/axios/axios to learn more about the valid request options.`; | ||
| throw new Error(e); | ||
| Object.keys(options).forEach(key => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
instance()andproject()methods are much more selective about which properties they will accept. The only accepted properties areparamsandproperties.The
instance()andproject()methods also now directly return the data instead of a response object.I am trying to quarantine the types for Axios. This makes it so we don't expose the underlying http client library. I am also making the set of acceptable properties you can pass into the options config an allow-list instead of an open obj, and checking it at runtime. This is potentially very breaking, so I want thoughts here from @stephenplusplus and @ofrobots :)