Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use execa, move post install test to system #127

Merged
merged 2 commits into from
Nov 19, 2018
Merged

refactor: use execa, move post install test to system #127

merged 2 commits into from
Nov 19, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Nov 19, 2018

Fixes #41. There are a few things happening here:

  • Moving the kitchen post install test over to system tests
  • Dropping await-spawn and a custom implementation of await spawn for execa
  • Moving the poorly named kitchen fixture in the system-tests to hook

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@JustinBeckwith JustinBeckwith merged commit 58a183a into googleapis:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an npm module for async spawn
3 participants