Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support multipart/related requests #610

Merged
merged 4 commits into from
Apr 3, 2024
Merged

feat: support multipart/related requests #610

merged 4 commits into from
Apr 3, 2024

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #491 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner April 2, 2024 20:41
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 2, 2024
@ddelgrosso1
Copy link
Contributor Author

Thanks @danielbankhead for the async generator guidance.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
danielduhh
danielduhh reviewed Apr 2, 2024
View reviewed changes
Copy link

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit and a question

src/common.ts Outdated Show resolved Hide resolved
src/common.ts Outdated Show resolved Hide resolved
src/gaxios.ts Show resolved Hide resolved
src/gaxios.ts Show resolved Hide resolved
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
danielbankhead
danielbankhead approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2024
@ddelgrosso1 ddelgrosso1 merged commit 086c824 into googleapis:main Apr 3, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Apr 3, 2024
Merged
@ddelgrosso1 ddelgrosso1 deleted the multipart-support branch July 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@danielduhh danielduhh danielduhh approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: support multipart requests
3 participants
@ddelgrosso1 @danielduhh @danielbankhead