-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade to gts v2 #232
Conversation
I can't wait to merge this 👍 |
samples/quickstart.js
Outdated
@@ -13,14 +13,14 @@ | |||
// limitations under the License. | |||
|
|||
// [START gaxios_quickstart] | |||
const {request} = require('gaxios'); | |||
const { request } = require('gaxios'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... how about disabling this option in prettier config to make the result much closer to what we have now?
"bracketSpacing": {
"description": "Print spaces between brackets.",
"default": true,
"type": "boolean"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nods we absolutely could do that. I was thinking of reducing the amount of prettier customizations we do, and keep it as close to the default config as possible. That includes dropping bracket spacing, and the trailing commas.
If we want to optimize for lowest changes, we could keep adding those customizations in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. There is a serious risk of starting a discussion about style here :)
I get your point about keeping minimal config, but one thing about gts
default style is that it more or less did what's explained in Google JavaScript Style Guide. For some reason I feel it might make sense to adhere to that style guide :) It puts no space between brackets, and uses trailing commas.
But again, I just thought that keeping the formatting (if not too hard) is a good idea, but I'm OK with either decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good :) gts update here:
google/gts#440
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 97.84% 98.49% +0.65%
==========================================
Files 6 4 -2
Lines 602 599 -3
Branches 102 95 -7
==========================================
+ Hits 589 590 +1
+ Misses 13 9 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very reasonable to me, I appreciate that the code changes are fairly minimal.
d26a325 commit d26a325 Author: Justin Beckwith <[email protected]> Date: Thu Mar 19 10:20:31 2020 -0700 chore(deps): upgrade to gts v2 (#232)
This is using a pre-release version of gts, but I think it's ready for a look. I'd honestly be ok with merging it as is. I want to put a few more miles on the new system before releasing 2.0.0.
A few things to discuss:
prettierignore
andeslintignore
with the new gts. We can no longer rely on thetsconfig
to tell us what files to look atFeedback welcomed 🤗