Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for universe domain #502

Merged
merged 14 commits into from
Jan 3, 2024
Merged

feat: add support for universe domain #502

merged 14 commits into from
Jan 3, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 14, 2023

  • CL-R1 Client Libraries must allow the end-user to configure the endpoint override alongside the universe
  • CL-R2 Client Libraries must use the universe_domain variable/property/method name
  • CL-R3 Client Libraries must use the universe_domain to form the service endpoint and should deprecate the hardcoded endpoint values
  • CL-R5 Client Libraries must use the universe_domain from the credentials to verify that the credentials can be used with the configured universe domain
    • CL-R5.1 If the end-user has not configured the universe_domain explicitly, the Client Libraries must use GDU as the configured universe domain.
    • CL-R5.2 The client libraries must not use the endpoint to validate the universe domain
  • CL-R6 Client Libraries should surface either the credentials or the universe_domain to the end-user
    • this is not currently supported (there are no "getters" on the client classes). I personally don't want to add support
    • CL-R6.1 Client Libraries should surface the service endpoint to the end-user
      • this is not currently supported (there are no "getters" on the client classes). I personally don't want to add support for it unless it's a hard requirement
  • CL-R7 Client Libraries must allow the end-user to configure the universe domain explicitly
  • CL-R8 Client Libraries must update the documentation if they allow the end-user to pass the authentication token/JWT instead of credentials - N/A
  • CL-R9 Libraries must avoid leaking the authentication tokens and user data to the GDU
  • CL-R10: Configuring mTLS with a universe domain other than GDU must throw an exception

@bshaffer bshaffer marked this pull request as ready for review November 15, 2023 23:29
@bshaffer bshaffer requested review from a team as code owners November 15, 2023 23:29
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer closed this Dec 13, 2023
@bshaffer bshaffer deleted the tpc branch December 13, 2023 20:01
@bshaffer
Copy link
Contributor Author

Dang, I tried renaming the branch to keep the PR open, but github still closed it :-/

@bshaffer bshaffer restored the tpc branch December 13, 2023 20:02
@bshaffer bshaffer reopened this Dec 13, 2023
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer enabled auto-merge (squash) January 3, 2024 20:47
@bshaffer bshaffer merged commit 5a26fac into main Jan 3, 2024
14 checks passed
@bshaffer bshaffer deleted the tpc branch January 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants