Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty or null access tokens #216

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

michaelbausor
Copy link
Contributor

Handle and test for empty or null access tokens, which may be returned by insecure/anonymous credentials.

@codecov-io
Copy link

codecov-io commented Sep 10, 2018

Codecov Report

Merging #216 into master will decrease coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #216      +/-   ##
=========================================
- Coverage   84.75%   84.7%   -0.06%     
=========================================
  Files          64      64              
  Lines        2467    2471       +4     
=========================================
+ Hits         2091    2093       +2     
- Misses        376     378       +2
Impacted Files Coverage Δ
src/ApiCore/Transport/HttpUnaryTransportTrait.php 34.78% <0%> (-3.32%) ⬇️
src/ApiCore/GapicClientTrait.php 87.83% <100%> (ø) ⬆️
src/ApiCore/CredentialsWrapper.php 90.9% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe157fe...0839082. Read the comment docs.

@michaelbausor michaelbausor merged commit ba7bac8 into googleapis:master Sep 11, 2018
@michaelbausor michaelbausor deleted the insecure-credentials branch September 11, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants