feat: GrpcClient.loadProtoJSON to load protobuf.js JSON proto #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 88.58% 88.55% -0.04%
==========================================
Files 43 43
Lines 7098 7123 +25
Branches 612 617 +5
==========================================
+ Hits 6288 6308 +20
- Misses 800 805 +5
Partials 10 10
Continue to review full report at Codecov.
|
feywind
approved these changes
Apr 23, 2021
| * In rare cases users might need to deallocate all memory consumed by loaded protos. | ||
| * This method will delete the proto cache content. | ||
| */ | ||
| static clearProtoCache() { |
There was a problem hiding this comment.
Actually... I kind of want to expose this in Pub/Sub, but that's a separate discussion. It would probably fix an issue with proto memory leaks.
There was a problem hiding this comment.
I believe it must be accessible from Pub/Sub, but let's talk about memory leaks separately: I believe that with caching there should be none :)
alexander-fenster
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the change to stop using
fsduring loading protos, replacing it withrequire(). This was inspired by the discussion in googleapis/nodejs-pubsub#1246.Since
@grpc/proto-loaderv0.6+ supports loading protos from protobuf.js JSON representation (.fromJSON), we can now avoid usingfsaltogether and justrequire()the proto JSON file, and then pass it to the proto loader. This will make all the bundlers much happier.The second part of this fix will be in the generator which would need to start calling the new
.loadProtoJSONinstead of the existing.loadProto.Note: the change to
isBrowserinvocation infallback.tsis unrelated, it just got caught by my linter and I fixed it. It's actually a bug!