fix: imports for node-fetch when using webpack #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 88.69% 88.58% -0.12%
==========================================
Files 43 43
Lines 7097 7098 +1
Branches 613 612 -1
==========================================
- Hits 6295 6288 -7
- Misses 792 800 +8
Partials 10 10
Continue to review full report at Codecov.
|
|
not sure about the codecov report... - if someone can point me to the right direction I'd be thankful 🙂 |
alexander-fenster
approved these changes
Mar 15, 2021
alexander-fenster
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Thanks @denniskribl! I believe the coverage will go up as soon as the remaining tests complete (I just started them). |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.11.3](https://www.github.com/googleapis/gax-nodejs/compare/v2.11.2...v2.11.3) (2021-04-22) ### Bug Fixes * fallback can now be a string ([#983](https://www.github.com/googleapis/gax-nodejs/issues/983)) ([d4e495a](https://www.github.com/googleapis/gax-nodejs/commit/d4e495af46176b8dd74595108f25a6df99ee042d)) * imports for node-fetch when using webpack ([#972](https://www.github.com/googleapis/gax-nodejs/issues/972)) ([505c6b8](https://www.github.com/googleapis/gax-nodejs/commit/505c6b8a3a53f1875617a2258869e4646a0e439b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially: googleapis/google-cloud-node#2933 (this comment)
Hey yall! This should fix the problem which was discussed here when initiating a client with the
fallback: trueoption.I can create another issue if needed :)