Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use @grpc/grpc-js v0.6.10 #633

Closed
wants to merge 1 commit into from

Conversation

alexander-fenster
Copy link
Contributor

Will be released as next.

@alexander-fenster alexander-fenster requested review from bcoe and a team October 31, 2019 22:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #633 into master will increase coverage by 6.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   81.73%   88.42%   +6.69%     
==========================================
  Files          61       65       +4     
  Lines        3964     4139     +175     
  Branches      312      320       +8     
==========================================
+ Hits         3240     3660     +420     
+ Misses        638      387     -251     
- Partials       86       92       +6
Impacted Files Coverage Δ
tools/prepublish.ts 100% <0%> (ø)
test/system-test/test.clientlibs.ts 91.93% <0%> (ø)
test/system-test/showcase-server.ts 79.41% <0%> (ø)
test/system-test/test.endtoend.ts 94.73% <0%> (ø)
...ixtures/google-gax-packaging-test-app/src/index.js 67.25% <0%> (+67.25%) ⬆️
...-gax-packaging-test-app/src/v1beta1/echo_client.js 89.85% <0%> (+89.85%) ⬆️
...oogle-gax-packaging-test-app/test/gapic-v1beta1.js 95.51% <0%> (+95.51%) ⬆️
...google-gax-packaging-test-app/src/v1beta1/index.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7428a26...94ab5a1. Read the comment docs.

@bcoe bcoe added the status: blocked Resolving the issue is dependent on other work. label Nov 4, 2019
@bcoe
Copy link
Contributor

bcoe commented Nov 4, 2019

@alexander-fenster it looks like there is some additional work being done to squash memory leaks here.

Let's pull this in once that thread reaches a resolution.

@alexander-fenster alexander-fenster deleted the grpc-js-0.6.10 branch November 8, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants