Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not hang in LRO forever if API returned nothing #436

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

alexander-fenster
Copy link
Contributor

Speech API LongRunningRecognize can return no result and no error in case if the input file has no speech in it. This should be fixed on the server side but it makes sense to stop waiting in LRO if there is nothing to wait for.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #436 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage    92.8%   92.67%   -0.14%     
==========================================
  Files          26       26              
  Lines        2753     2757       +4     
  Branches       72       72              
==========================================
  Hits         2555     2555              
- Misses        186      190       +4     
  Partials       12       12
Impacted Files Coverage Δ
src/longrunning.ts 94.64% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8d268...725ff22. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #436 into master will increase coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage    92.8%   92.81%   +<.01%     
==========================================
  Files          26       26              
  Lines        2753     2769      +16     
  Branches       72       72              
==========================================
+ Hits         2555     2570      +15     
- Misses        186      187       +1     
  Partials       12       12
Impacted Files Coverage Δ
src/longrunning.ts 98.21% <100%> (+0.06%) ⬆️
test/longrunning.ts 93.61% <91.66%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8d268...725ff22. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit fd1b4f0 into master Mar 1, 2019
@alexander-fenster alexander-fenster deleted the lro-error branch March 1, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants