chore: don't run system tests with grpc-js #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kinwa91 will enable system tests with grpc-js as a separate Kokoro task.
googlebot
added
the
cla: yes
alexander-fenster
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
alexander-fenster
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@JustinBeckwith @kinwa91 Since #418 is on its way, can you approve&merge this one so that flaky system tests don't interfere with PRs? Thanks! |
jkwlui
approved these changes
Feb 9, 2019
alexander-fenster
added a commit
that referenced
this pull request
Feb 11, 2019
This was originally merged in #417 but looks like it got lost in merges. We still need to remove this since we now have a separate Kokoro task for grpc-js.
3 tasks
alexander-fenster
added a commit
that referenced
this pull request
Feb 11, 2019
This was originally merged in #417 but looks like it got lost in merges. We still need to remove this since we now have a separate Kokoro task for grpc-js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kinwa91 will enable system tests with grpc-js as a separate Kokoro task.
It's a little bit flaky now so will likely bring more harm than good.
But good news is that it works (#400)!