Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include format and lint tools for samples #359

Merged
merged 3 commits into from
Nov 19, 2018
Merged

chore: include format and lint tools for samples #359

merged 3 commits into from
Nov 19, 2018

Conversation

JustinBeckwith
Copy link
Contributor

This is just gardening to keep things consistent across the repos.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2018
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexander-fenster
Copy link
Contributor

...other than the failing system tests in kokoro :(

@alexander-fenster
Copy link
Contributor

OK the system tests error is not related to your change. It's the pubsub that for some weird reason cannot compile. Started after pubsub v0.21.1 (last pass on v0.20.1), first fail on v0.21.1). You can go ahead and merge it, I will take a look at the failure (something wrong with starting tsc).

@JustinBeckwith JustinBeckwith merged commit 3ae093c into googleapis:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants