Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable noImplicitThis in the tsconfig #347

Merged
merged 1 commit into from
Nov 9, 2018
Merged

refactor: enable noImplicitThis in the tsconfig #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,20 @@
"typescript": "~3.1.5"
},
"scripts": {
"codecov": "istanbul test ./node_modules/mocha/bin/_mocha -- build/test --reporter spec --slow 500 && ./node_modules/codecov/bin/codecov",
"codecov": "nyc mocha build/test --reporter spec --slow 500 && codecov",
"docs": "echo no docs 📗",
"gen-parser": "pegjs lib/path_template_parser.pegjs",
"test": "npm run test-only",
"test-only": "istanbul test ./node_modules/mocha/bin/_mocha -- build/test --reporter spec --slow 500",
"test-only": "nyc mocha build/test --reporter spec --slow 500",
"publish-gh-pages": "bash ./publish-gh-pages.sh",
"lint": "gts check",
"clean": "gts clean",
"compile": "tsc -p . && cp src/operations_client_config.json build/src",
"compile": "tsc -p . && cp src/*.json build/src && cp src/*.js build/src",
"fix": "gts fix",
"prepare": "npm run compile",
"pretest-only": "npm run compile",
"posttest": "npm run lint",
"system-test": "nyc mocha --timeout 1200000 build/system-test/system.js",
"system-test": "nyc mocha --timeout 1200000 build/system-test",
"samples-test": "echo no sample tests 😱"
},
"repository": "googleapis/gax-nodejs",
Expand Down
2 changes: 1 addition & 1 deletion src/path_template_parser.ts → src/path_template_parser.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions test/api_callable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import * as sinon from 'sinon';

import * as gax from '../src/gax';
import {GoogleError} from '../src/GoogleError';

import * as utils from './utils';

const fail = utils.fail;
Expand All @@ -45,8 +44,8 @@ const FAKE_STATUS_CODE_2 = (utils as any).FAKE_STATUS_CODE_1 + 1;

describe('createApiCall', () => {
it('calls api call', (done) => {
let deadlineArg;
function func(argument, metadata, options, callback) {
let deadlineArg: {};
function func(argument: {}, metadata: {}, options, callback) {
deadlineArg = options.deadline;
callback(null, argument);
}
Expand Down
3 changes: 1 addition & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"compilerOptions": {
"rootDir": ".",
"outDir": "build",
"noImplicitAny": false,
"noImplicitThis": false
"noImplicitAny": false
},
"include": [
"src/*.ts",
Expand Down