-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: system tests for gax #334
Conversation
I need `npm link` in system tests for gax. It does not change any behavior for other libraries. Context: googleapis/gax-nodejs#334
It even works in Kokoro! FYI, here is the coverage of gax code by those system tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is freaking awesome.
package.json
Outdated
@@ -67,7 +70,7 @@ | |||
"prepare": "npm run compile", | |||
"pretest-only": "npm run compile", | |||
"posttest": "npm run lint", | |||
"system-test": "echo no system tests 😱", | |||
"system-test": "nyc mocha --no-timeouts build/system-test/system.js", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
package.json
Outdated
@@ -82,5 +85,13 @@ | |||
"homepage": "https://github.com/googleapis/gax-nodejs#readme", | |||
"engines": { | |||
"node": ">=6.0.0" | |||
}, | |||
"nyc": { | |||
"include": [ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
const maxBuffer = 10 * 1024 * 1024; | ||
console.log(`Execute: ${command} [cwd: ${cwd}]`); | ||
return new Promise<ExecuteResult>((resolve, reject) => { | ||
cp.exec(command, {cwd, maxBuffer}, (err, stdout, stderr) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tsconfig.json
Outdated
@@ -9,6 +9,7 @@ | |||
}, | |||
"include": [ | |||
"src/*.ts", | |||
"test/*.ts" | |||
"test/*.ts", | |||
"system-test/*.ts" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I need `npm link` in system tests for gax. It does not change any behavior for other libraries. Context: googleapis/gax-nodejs#334
Introducing system tests for gax. The test does the following:
npm link
local gax;I expect it will make updating and/or refactoring gax less scary.
Changes to CircleCI config for
synthtool
: googleapis/synthtool#114.