fix: do not throw DeprecationWarnings for legacy retry behavior #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feywind
approved these changes
Jan 31, 2024
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>4.3.0</summary> ## [4.3.0](https://togithub.com/googleapis/gax-nodejs/compare/v4.2.1...v4.3.0) (2024-01-31) ### Features * implement support for Trusted Partner Cloud ([#1552](https://togithub.com/googleapis/gax-nodejs/issues/1552)) ([d51218c](https://togithub.com/googleapis/gax-nodejs/commit/d51218c23d4afe437285a55a44a39f64bdb3736d)) ### Bug Fixes * do not throw DeprecationWarnings for legacy retry behavior ([#1551](https://togithub.com/googleapis/gax-nodejs/issues/1551)) ([2f39306](https://togithub.com/googleapis/gax-nodejs/commit/2f39306a441ce08374fe069ab1e1892871715a77)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client library uses legacy retry behavior, the deprecation warning is useless because the user who receives it cannot do anything about it. We don't need to throw it at this point.