feat: implement support for Trusted Partner Cloud #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
sofisl
approved these changes
Jan 31, 2024
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>4.3.0</summary> ## [4.3.0](https://togithub.com/googleapis/gax-nodejs/compare/v4.2.1...v4.3.0) (2024-01-31) ### Features * implement support for Trusted Partner Cloud ([#1552](https://togithub.com/googleapis/gax-nodejs/issues/1552)) ([d51218c](https://togithub.com/googleapis/gax-nodejs/commit/d51218c23d4afe437285a55a44a39f64bdb3736d)) ### Bug Fixes * do not throw DeprecationWarnings for legacy retry behavior ([#1551](https://togithub.com/googleapis/gax-nodejs/issues/1551)) ([2f39306](https://togithub.com/googleapis/gax-nodejs/commit/2f39306a441ce08374fe069ab1e1892871715a77)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Closed
antonstefer
reviewed
Mar 7, 2024
Comment on lines
+414
to
+425
| if (!options.universeDomain) { | ||
| options.universeDomain = 'googleapis.com'; | ||
| } | ||
| if (options.universeDomain) { | ||
| const universeFromAuth = await this.auth.getUniverseDomain(); | ||
| if (universeFromAuth && options.universeDomain !== universeFromAuth) { | ||
| throw new Error( | ||
| `The configured universe domain (${options.universeDomain}) does not match the universe domain found in the credentials (${universeFromAuth}). ` + | ||
| "If you haven't configured the universe domain explicitly, googleapis.com is the default." | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
await this.auth.getUniverseDomain() is called even if there is no universe domain configured in the options (because it then falls back to googleapis.com) which takes a considerable amount of time. In my case around 300ms. Should it really work that way? @alexander-fenster
This change slows down my project testing setup a lot because each test-bigtable creation takes around 300ms longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client libraries will start passing
universeDomaintocreateStubmethod for both gRPC and REST transports. Perform some validation as required.Related: googleapis/google-auth-library-nodejs#1732