-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add queryString to snake_case
when using the fallback REST Method.
#1312
Comments
[Additional Comment] It seems like Google pub/sub |
Hi @sckimynwa, gax-nodejs explicitly changes snake case query string paramaters to camel case. However, you're right the AIP comments are misleading:
We've created a PR to update the documentation. Thanks for submitting the bug! |
Currently, googlers confirmed that camelCase should be used for Http Json transcoded apis googleapis/gax-nodejs#1312 aip-dev/google.aip.dev#934 add a way to serve HttpJsonTranscoding with camelCase parameter keys
Currently, googlers confirmed that camelCase should be used for Http Json transcoded apis googleapis/gax-nodejs#1312 aip-dev/google.aip.dev#934 add a way to serve HttpJsonTranscoding with camelCase parameter keys
Currently, googlers confirmed that camelCase should be used for Http Json transcoded apis googleapis/gax-nodejs#1312 aip-dev/google.aip.dev#934 add a way to serve HttpJsonTranscoding with camelCase parameter keys
I'm using gapic-generator-typescript to generate client-side REST fallback methods from protobuf.
which internally depends on
gax-nodejs
.when requesting "Post" method with body, it works fine. but when i use "Get" method with query string
(to support pagination features like
page_size
,page_token
), it sendscamelCased
query string.so when i checked implemented code on this module, it works like this.
in comment, it says "use camel case for query string".
I'm wondering why gax-nodejs formats query string as "camelCase". because in google aip examples,
it seems like query string would be "snake_case". (https://google.aip.dev/127)
If you have any ideas of supporting
snake_case
in queryString?(By the way, i forked this repository and use
camelToSnakeCase
Method to make query string snake _case)The text was updated successfully, but these errors were encountered: