This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
switch from NettyChannelBuilder to ManagedChannelBuilder (#208) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
============================================
+ Coverage 70.52% 70.54% +0.02%
Complexity 492 492
============================================
Files 69 69
Lines 2551 2550 -1
Branches 269 269
============================================
Hits 1799 1799
+ Misses 653 652 -1
Partials 99 99
Continue to review full report at Codecov.
|
| @@ -116,8 +115,8 @@ private ManagedChannel createChannel(Executor executor) throws IOException { | |||
| interceptors.add(new ClientAuthInterceptor(credentialsProvider.getCredentials(), executor)); | |||
| interceptors.add(new HeaderInterceptor(serviceHeader())); | |||
|
|
|||
| return NettyChannelBuilder.forAddress(serviceAddress, port) | |||
| .negotiationType(NegotiationType.TLS) | |||
| //By default ManagedChannel uses TLS negotiationType | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Have you run the tests in api-client-staging with this change? |
|
@neozwu To run the staging tests with this PR:
Hope this helps! Please let me know if anything does not work for you. |
neozwu
force-pushed
the
switch-to-managedchannelbuilder
branch
from
be34ded to
67efe6d
Compare
|
@garrettjonesgoogle Testing against api-client-staging all passed. PTAL |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ManagedChannelBuilderto replaceNettyChannelBuilder, since the later is experimental. TheManagedChannelBuilderat runtime will loadNettyChannelBuilderon all platforms except for Android, in which caseOkHttpChannelBuilderwill be used.