feat: Support universe domain environment variable #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Jan 14, 2025
| @@ -750,6 +750,22 @@ public async Task<TClient> BuildAsync(IServiceProvider provider, CancellationTok | |||
| protected virtual ChannelBase CreateChannel(string endpoint, ChannelCredentials credentials) => | |||
| LastCreatedChannel = EffectiveGrpcAdapter.CreateChannel(ServiceMetadata, endpoint, credentials, GetChannelOptions()); | |||
|
|
|||
| /// <summary> | |||
| /// Retrives the value of the environment variable with <paramref name="name"/>, | |||
| /// Retrives the value of the environment variable with <paramref name="name"/>, | ||
| /// mapping empty or whitespace-only strings to null. | ||
| /// </summary> | ||
| private static string GetNonEmptyOrNullEnvironmentVariable(string name) => GetNonEmptyOrNullValue(name, Environment.GetEnvironmentVariable); |
There was a problem hiding this comment.
Maybe GetNonWhiteSpaceOrNull? I'd expected a call to string.IsNullOrEmpty later rather than string.IsNullOrWhiteSpace.
There was a problem hiding this comment.
Yes, that's better, changing...
amanda-tarafa
commented
Jan 14, 2025
| @@ -750,6 +750,22 @@ public async Task<TClient> BuildAsync(IServiceProvider provider, CancellationTok | |||
| protected virtual ChannelBase CreateChannel(string endpoint, ChannelCredentials credentials) => | |||
| LastCreatedChannel = EffectiveGrpcAdapter.CreateChannel(ServiceMetadata, endpoint, credentials, GetChannelOptions()); | |||
|
|
|||
| /// <summary> | |||
| /// Retrives the value of the environment variable with <paramref name="name"/>, | |||
| /// Retrives the value of the environment variable with <paramref name="name"/>, | ||
| /// mapping empty or whitespace-only strings to null. | ||
| /// </summary> | ||
| private static string GetNonEmptyOrNullEnvironmentVariable(string name) => GetNonEmptyOrNullValue(name, Environment.GetEnvironmentVariable); |
There was a problem hiding this comment.
Yes, that's better, changing...
amanda-tarafa
force-pushed
the
universe-env-var
branch
from
a6d984b to
b139283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards b/325308829