Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGAPIC: which exception should be thrown if transcoding fails? #659

Closed
jskeet opened this issue Dec 7, 2022 · 1 comment · Fixed by #660, #633 or #664
Closed

REGAPIC: which exception should be thrown if transcoding fails? #659

jskeet opened this issue Dec 7, 2022 · 1 comment · Fixed by #660, #633 or #664
Assignees
@jskeet
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Dec 7, 2022

If a request is invalid in a way that makes transcoding fail (e.g. it's missing a required field, or that field's value is inappropriate) we currently throw an ArgumentException. If the request can be transcoded, but is otherwise invalid, the server will fail instead and we'll get an RpcException. Should we create an "artificial" RpcException instead in this case?
@jskeet jskeet self-assigned this Dec 7, 2022
@jskeet jskeet added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 7, 2022
@amanda-tarafa
Copy link
Collaborator

+1 to creating an RpcException. That we need some fields to actually make the call is an implementation detail, from the caller point of view, the request is as invalid as one that reaches the server and fails there.

jskeet added a commit to jskeet/gax-dotnet that referenced this issue Dec 7, 2022
@jskeet
fix: Throw RpcException if transcoding fails
43ef81e 
Fixes googleapis#659
@jskeet jskeet mentioned this issue Dec 7, 2022
Merged
jskeet added a commit to jskeet/gax-dotnet that referenced this issue Dec 7, 2022
@jskeet
fix: Throw RpcException if transcoding fails
cace72b 
Fixes googleapis#659
jskeet added a commit that referenced this issue Dec 7, 2022
@jskeet
fix: Throw RpcException if transcoding fails
49c7349 
Fixes #659
@release-please release-please bot mentioned this issue Dec 7, 2022
Merged
@jskeet jskeet mentioned this issue Dec 8, 2022
Merged
@release-please release-please bot mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@jskeet @amanda-tarafa