Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd,server,util): replace use of github.com/golang/protobuf/proto #1534

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

julieqiu
Copy link
Member

Fixes #1525

@julieqiu julieqiu requested review from a team as code owners August 19, 2024 01:07
Use google.golang.org/protobuf/proto instead. Per staticcheck:

"github.com/golang/protobuf/proto" is deprecated: Use the
"google.golang.org/protobuf/proto" package instead.  (SA1019)
@codyoss
Copy link
Member

codyoss commented Aug 19, 2024

@julieqiu are we still retaining some refs here? I would have expected the go.mod to have an update to remove the direct dep too.

@julieqiu
Copy link
Member Author

@codyoss - I only did github.com/golang/protobuf/proto in this CL, not the entire github.com/golang/protobuf module.

@julieqiu julieqiu enabled auto-merge (squash) August 19, 2024 17:00
@julieqiu julieqiu merged commit b9f8777 into googleapis:main Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf/proto
2 participants