Skip to content

Commit

Permalink
feat: Add google.api.api_version annotation to echo.proto (#1484)
Browse files Browse the repository at this point in the history
* feat: Add google.api.api_version annotation to echo.proto

* update the api_version to a nonsense value to refelect that it should be opaque to clients as per AIP

* Address review feedback
  • Loading branch information
parthea authored Apr 9, 2024
1 parent 0622c2f commit 9a2298b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions schema/google/showcase/v1beta1/echo.proto
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ service Echo {
// This service is meant to only run locally on the port 7469 (keypad digits
// for "show").
option (google.api.default_host) = "localhost:7469";
// See https://github.com/aip-dev/google.aip.dev/pull/1331
option (google.api.api_version) = "v1_20240408";

// This method simply echoes the request. This method showcases unary RPCs.
rpc Echo(EchoRequest) returns (EchoResponse) {
Expand Down

0 comments on commit 9a2298b

Please sign in to comment.