Refactor PHP discovery snippetgen for MVVM #714

saicheems · 2016-11-02T20:23:08Z

No description provided.

src/main/java/com/google/api/codegen/discovery/transformer/php/PhpSampleNamer.java

+
+  @Override
+  public String getSampleApplicationName(String apiTypeName) {
+    // Unfortunate replacement that's necessary because the API type name is of a special format.


src/main/java/com/google/api/codegen/discovery/transformer/php/PhpSampleTypeNameConverter.java

+    if (typeInfo.isMessage()) {
+      return new TypeName(apiTypeName + "_" + typeInfo.message().typeName());
+    }
+    return getTypeNameForElementType(typeInfo);


src/test/java/com/google/api/codegen/testdata/discoveries/php/php_translate.v2.json.baseline

-
-// TODO: Change placeholder below to desired API key:
-$client->setDeveloperKey('{MY-API-KEY}');
+$client->setDeveloperKey(''); // TODO: Update placeholder with desired API key.


src/test/java/com/google/api/codegen/testdata/discoveries/php/php_translate.v2.json.baseline

 // The text to detect
-$q = [];
-
+$q = array();  // TODO: Update placeholder value.


codecov-io · 2016-11-03T21:01:45Z

Current coverage is 80.91% (diff: 90.28%)

Merging #714 into master will decrease coverage by 0.42%

@@             master       #714   diff @@
==========================================
  Files           291        296     +5   
  Lines         11074      11293   +219   
  Methods           0          0          
  Messages          0          0          
  Branches       1459       1490    +31   
==========================================
+ Hits           9008       9138   +130   
- Misses         1669       1749    +80   
- Partials        397        406     +9

Powered by Codecov. Last update b485d88...546ecfa

.../java/com/google/api/codegen/testdata/discoveries/java/java_storagetransfer.v1.json.baseline

    Storagetransfer storagetransferService = createStoragetransferService();
-    Storagetransfer.GoogleServiceAccounts.Get request = storagetransferService.googleServiceAccounts().get(projectId);
+    Storagetransfer.V1.GetGoogleServiceAccount request = storagetransferService.v1().getGoogleServiceAccount();


src/test/java/com/google/api/codegen/testdata/discoveries/php/php_bigquery.v2.json.baseline

-  foreach ($response['datasets'] as $dataset_list._datasets) {
-    // TODO: Change code below to process each `dataset_list._datasets` resource:
-    echo '<pre>', var_export($dataset_list._datasets, true), '</pre>', "\n";
+  foreach ($response['datasets'] as $datasets) {


...test/java/com/google/api/codegen/testdata/discoveries/php/php_sqladmin.v1beta4.json.baseline


+$optParams = [];
+do {


src/test/java/com/google/api/codegen/testdata/discoveries/php/php_storage.v1.json.baseline


+$optParams = [];
 // TODO: To download media content, use:


saicheems force-pushed the php branch 2 times, most recently from e45c22c to 548ec88 Compare November 2, 2016 20:34

saicheems assigned vchudnov-g and tcoffee-google Nov 2, 2016

Refactor PHP discovery snippetgen for MVVM

affbb66

saicheems force-pushed the php branch from 548ec88 to affbb66 Compare November 2, 2016 20:37

Fix method name component generation

291f2ce

saicheems force-pushed the php branch from 992b1f0 to 291f2ce Compare November 2, 2016 21:13

Fix a few more bugs

0407f6f

tcoffee-google suggested changes Nov 2, 2016

View reviewed changes

saicheems added 2 commits November 2, 2016 16:24

Change array declaration and update overrides

a27cf51

Add apiCanonicalName to SampleConfig

ad5e2db

tcoffee-google approved these changes Nov 3, 2016

View reviewed changes

Add all baselines

2798489

tcoffee-google reviewed Nov 3, 2016

View reviewed changes

Address PR feedback

546ecfa

tcoffee-google approved these changes Nov 4, 2016

View reviewed changes

saicheems merged commit f77724f into googleapis:master Nov 7, 2016

saicheems deleted the php branch November 7, 2016 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor PHP discovery snippetgen for MVVM #714

Refactor PHP discovery snippetgen for MVVM #714

saicheems commented Nov 2, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

codecov-io commented Nov 3, 2016 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.


		$optParams = [];
		do {

Refactor PHP discovery snippetgen for MVVM #714

Refactor PHP discovery snippetgen for MVVM #714

Conversation

saicheems commented Nov 2, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

codecov-io commented Nov 3, 2016 • edited Loading

Current coverage is 80.91% (diff: 90.28%)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

codecov-io commented Nov 3, 2016 •

edited

Loading