Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

feat: adds reserved name support for PHP and reserved name tests #3100

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

bshaffer
Copy link
Contributor

A new API coming out soon has a proto class Namespace, which is breaking for PHP client libraries.

See https://github.com/protocolbuffers/protobuf/pull/7268/files, which ensures the protobuf c library follows the same rules

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #3100 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3100      +/-   ##
===========================================
- Coverage     87.14%   87.1%   -0.05%     
+ Complexity     6045    6038       -7     
===========================================
  Files           494     494              
  Lines         23955   23954       -1     
  Branches       2599    2599              
===========================================
- Hits          20876   20864      -12     
- Misses         2225    2230       +5     
- Partials        854     860       +6
Impacted Files Coverage Δ Complexity Δ
.../com/google/api/codegen/util/php/PhpTypeTable.java 84.21% <100%> (+3.56%) 16 <6> (+3) ⬆️
...ransformer/ruby/RubyApiMethodParamTransformer.java 92.59% <0%> (-6.18%) 24% <0%> (-3%)
...ransformer/py/PythonApiMethodParamTransformer.java 94.33% <0%> (-4.72%) 24% <0%> (-3%)
...api/codegen/transformer/ruby/RubySurfaceNamer.java 93.46% <0%> (-1.01%) 92% <0%> (-1%)
...om/google/api/codegen/config/FlatteningConfig.java 72.34% <0%> (-0.86%) 49% <0%> (-2%)
.../google/api/codegen/config/GapicProductConfig.java 82.24% <0%> (-0.04%) 105% <0%> (ø)
...e/api/codegen/transformer/InitCodeTransformer.java 95.31% <0%> (+0.17%) 118% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cdacb...857afff. Read the comment docs.

@bshaffer bshaffer changed the title Adds reserved name support for PHP and adds reserved names to tests feat: adds reserved name support for PHP and reserved name tests Mar 3, 2020
@bshaffer bshaffer requested a review from yihanzhen March 3, 2020 20:01
Copy link
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer removed the request for review from andreamlin March 4, 2020 22:17
@bshaffer bshaffer merged commit ef5d22b into googleapis:master Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants