This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
feat: adds reserved name support for PHP and reserved name tests #3100
Merged
bshaffer
merged 4 commits into
googleapis:master
from
bshaffer:escape-reserved-names-php
Mar 9, 2020
Merged
feat: adds reserved name support for PHP and reserved name tests #3100
bshaffer
merged 4 commits into
googleapis:master
from
bshaffer:escape-reserved-names-php
Mar 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
===========================================
- Coverage 87.14% 87.1% -0.05%
+ Complexity 6045 6038 -7
===========================================
Files 494 494
Lines 23955 23954 -1
Branches 2599 2599
===========================================
- Hits 20876 20864 -12
- Misses 2225 2230 +5
- Partials 854 860 +6
Continue to review full report at Codecov.
|
bshaffer
changed the title
Adds reserved name support for PHP and adds reserved names to tests
feat: adds reserved name support for PHP and reserved name tests
Mar 3, 2020
yihanzhen
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dwsupplee
reviewed
Mar 3, 2020
src/test/java/com/google/api/codegen/gapic/testdata/php/php_library.baseline
Outdated
Show resolved
Hide resolved
bshaffer
force-pushed
the
escape-reserved-names-php
branch
from
March 4, 2020 22:28
2472018
to
dff27ee
Compare
dwsupplee
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new API coming out soon has a proto class
Namespace
, which is breaking for PHP client libraries.See https://github.com/protocolbuffers/protobuf/pull/7268/files, which ensures the protobuf c library follows the same rules