Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

SampleGen: Adjust C# region tags location #2886

Merged
merged 3 commits into from
Jul 25, 2019
Merged

SampleGen: Adjust C# region tags location #2886

merged 3 commits into from
Jul 25, 2019

Conversation

yihanzhen
Copy link
Contributor

Fix #2873

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #2886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2886   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     5853     5853           
=========================================
  Files           477      477           
  Lines         23223    23223           
  Branches       2507     2507           
=========================================
  Hits          20284    20284           
  Misses         2100     2100           
  Partials        839      839

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a823d...5fed1b0. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #2886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2886   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     5853     5853           
=========================================
  Files           477      477           
  Lines         23223    23223           
  Branches       2507     2507           
=========================================
  Hits          20284    20284           
  Misses         2100     2100           
  Partials        839      839

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a823d...0ce4498. Read the comment docs.

@yihanzhen yihanzhen changed the title SampleGen: Move C# start region tags down SampleGen: Move C# start region tags inside sample namespace Jul 25, 2019
@yihanzhen yihanzhen changed the title SampleGen: Move C# start region tags inside sample namespace SampleGen: Adjust C# region tags location Jul 25, 2019
chrisdunelm
chrisdunelm approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@chrisdunelm chrisdunelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/test/java/com/google/api/codegen/gapic/testdata/csharp/csharp_library.baseline

public class DeleteShelfAsyncFlattenedAsyncEmptyResponseTypeWithResponseHandlingMain {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming is a little crazy!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That's to test all samples have unique class names when users happen to provide the same name for two samples. It should never happen in production :)

@yihanzhen yihanzhen merged commit df80c15 into googleapis:master Jul 25, 2019
@noahdietz noahdietz mentioned this pull request Aug 1, 2019
Merged
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
@yihanzhen @busunkim96
SampleGen: Adjust C# region tags location (googleapis#2886)
ff34946 
Fix googleapis#2873
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdunelm chrisdunelm chrisdunelm approved these changes

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g

@beccasaurus beccasaurus Awaiting requested review from beccasaurus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. Core: Sample-gen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SampleGen: C# region tag location
3 participants
@yihanzhen @chrisdunelm @googlebot