Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Account for placeholders in additional bindings #2416

Merged

Conversation

dwsupplee
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #2416 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2416      +/-   ##
============================================
+ Coverage     86.72%   86.72%   +<.01%     
  Complexity     5241     5241              
============================================
  Files           458      458              
  Lines         20870    20873       +3     
  Branches       2252     2252              
============================================
+ Hits          18099    18102       +3     
  Misses         1968     1968              
  Partials        803      803
Impacted Files Coverage Δ Complexity Δ
...en/transformer/php/PhpGapicSurfaceTransformer.java 93.03% <100%> (+0.07%) 41 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f282c...92b1644. Read the comment docs.

@michaelbausor
Copy link
Contributor

Can we also update our tests so that this change is visible in the baseline file? I presume we will need to modify an existing method in our test proto (e.g. https://github.com/googleapis/gapic-generator/blob/master/src/test/java/com/google/api/codegen/testsrc/libraryproto/library.proto#L130) so that it has an additional binding with a different placeholder structure.

@dwsupplee
Copy link
Contributor Author

@michaelbausor Good thought. I've added 0a9d59d and 92b1644. PTAL and let me know what you think when you have a moment.

@dwsupplee dwsupplee merged commit 9209535 into googleapis:master Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants