Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Add unit tests for CommentPatterns regular expressions #722

Closed
swcloud opened this issue Nov 4, 2016 · 3 comments
Closed

Add unit tests for CommentPatterns regular expressions #722

swcloud opened this issue Nov 4, 2016 · 3 comments
Assignees
@evaogbe
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. Test type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@swcloud
Copy link
Contributor

swcloud commented Nov 4, 2016

While fixing #716, we found that there are no comprehensive unit test that are written for the following classes:

CommentPatterns.java
RDocCommentFixer.java
PythonSphinxCommentFixer.java
JSDocCommentFixer.java

While #716 PR provides unit tests for the above classes for its specific issues, these classes should have more comprehensive unit tests.
@swcloud swcloud mentioned this issue Nov 4, 2016
Merged
@swcloud swcloud added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. Test labels Dec 5, 2016
@evaogbe evaogbe added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 14, 2017
@evaogbe
Copy link
Contributor

evaogbe commented Aug 14, 2017

This should now be the CommentReformatters.

@geigerj
Copy link
Contributor

geigerj commented Aug 14, 2017

Ack. Specifically, if I recall correctly, the context was that the regexes were quite complicated and some test cases would have helped, so that would mean testing CommentPatterns.

@geigerj geigerj changed the title Add unit tests for Python/Ruby/NodeJS CommentFixer Add unit tests for CommentPatterns regular expressions Aug 14, 2017
@geigerj geigerj removed their assignment Feb 26, 2018
evaogbe added a commit to evaogbe/toolkit that referenced this issue Feb 11, 2019
@evaogbe
Add test for GoCommentReformatter.
189f922 
Updates googleapis#722
@evaogbe evaogbe mentioned this issue Feb 11, 2019
Merged
evaogbe added a commit to evaogbe/toolkit that referenced this issue Feb 12, 2019
@evaogbe
Parse Ruby comments as CommonMark
3981768 
Updates the formatting of Ruby comments to expect comments in the format 
of [CommonMark](https://commonmark.org/). Proto comments generally 
follow the CommonMark spec.

Replaces ad hoc comment transformations with a visitor for the Markdown 
elements. Adds tests for the RubyCommentReformatter.

Cleans up comment regex patterns.

Updates googleapis#722
@evaogbe evaogbe mentioned this issue Feb 12, 2019
Closed
evaogbe added a commit that referenced this issue Feb 27, 2019
@evaogbe
Add test for GoCommentReformatter (#2559)
f37dca5 
Add test for GoCommentReformatter.

Updates #722
@evaogbe
Copy link
Contributor

evaogbe commented Mar 29, 2019

Obsolete since we are migrating to microgenerators

@evaogbe evaogbe closed this as completed Mar 29, 2019
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this issue Nov 7, 2019
@evaogbe @busunkim96
Add test for GoCommentReformatter (googleapis#2559)
ec46686 
Add test for GoCommentReformatter.

Updates googleapis#722
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@evaogbe evaogbe

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. Test type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evaogbe @geigerj @swcloud