Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add licenses to all files #101

Merged
merged 1 commit into from
Nov 4, 2019
Merged

chore: add licenses to all files #101

merged 1 commit into from
Nov 4, 2019

Conversation

alexander-fenster
Copy link
Contributor

Adding Apache 2.0 license to all our source files.

@bcoe Can we please have a license checker bot enabled on this repo? Thank you!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2019
xiaozhenliu-gg5
xiaozhenliu-gg5 approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great!

I'm wondering how about we put the license in _license.njk as well since we have the helper file.

@alexander-fenster
Copy link
Contributor Author

@xiaozhenliu-gg5 The rule is to put a license into all source files. It's arguable if .njk files are source files or not, but since it's easy to add the license as a comment, let's just do it.

@alexander-fenster alexander-fenster merged commit c6be54f into master Nov 4, 2019
@alexander-fenster alexander-fenster deleted the add-license branch November 4, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @xiaozhenliu-gg5 @googlebot