Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing DEFAULT_HOST should still result in compiling code #2051

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: missing DEFAULT_HOST should still result in compiling code #2051

wants to merge 4 commits into from

Conversation

achew22
Copy link

@achew22 achew22 commented Jun 24, 2024

Previously the code would emit

  DEFAULT_HOST: str =

Note that there is nothing at the end of the line. Now it emits

  DEFAULT_HOST: str = ''

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@achew22
Missing DEFAULT_HOST should still result in compiling code
f8410ea 
Previously the code would emit

```python
  DEFAULT_HOST: str =
```

Note that there is nothing at the end of the line. Now it emits

```python
  DEFAULT_HOST: str = ''
```
@achew22 achew22 requested a review from a team as a code owner June 24, 2024 23:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 24, 2024
vchudnov-g
vchudnov-g approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix!

@vchudnov-g vchudnov-g changed the title Missing DEFAULT_HOST should still result in compiling code fix: missing DEFAULT_HOST should still result in compiling code Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

@vchudnov-g vchudnov-g

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achew22 @vchudnov-g