Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize file names #1238

Closed
parthea opened this issue Mar 16, 2022 · 0 comments · Fixed by #1236
Closed

Sanitize file names #1238

parthea opened this issue Mar 16, 2022 · 0 comments · Fixed by #1236
Assignees
@parthea
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 16, 2022

There is a syntax issue here with the generated client for Cloud Run. The issue is that there is a proto file here which does not use the correct snake case format.

We should fix this issue in the generator as it may be difficult to rename the proto. I've opened a PR to improve the api-linter to help catch the issue upstream in the future.

To workaround the issue, the line from google.cloud.run_v2.types import k8s.min should be changed to from google.cloud.run_v2.types import k8s_min.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 16, 2022
@parthea parthea self-assigned this Mar 16, 2022
@parthea parthea mentioned this issue Mar 16, 2022
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sanitize file names googleapis/gapic-generator-python
2 participants
@parthea @yoshi-automation