Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-191): valid characters in filename #948

Merged
merged 5 commits into from
Mar 18, 2022
Merged

fix(AIP-191): valid characters in filename #948

merged 5 commits into from
Mar 18, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 16, 2022

Fixes #947

@parthea parthea requested a review from a team March 16, 2022 14:32
noahdietz
noahdietz reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

rules/aip0191/aip0191.go Outdated Show resolved Hide resolved
rules/aip0191/aip0191.go Outdated Show resolved Hide resolved
@parthea
Copy link
Contributor Author

parthea commented Mar 16, 2022

The status checks are stuck. I'm going to try closing and re-opening the PR.

@parthea parthea closed this Mar 16, 2022
@parthea parthea reopened this Mar 16, 2022
noahdietz
noahdietz approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending removal of A-Z from the "valid regex"

@parthea parthea mentioned this pull request Mar 16, 2022
Closed
@noahdietz noahdietz enabled auto-merge (squash) March 16, 2022 22:00
@noahdietz
Copy link
Collaborator

closing/reopening to trigger Actions

@noahdietz noahdietz closed this Mar 18, 2022
auto-merge was automatically disabled March 18, 2022 18:05

Pull request was closed

@noahdietz noahdietz reopened this Mar 18, 2022
@noahdietz noahdietz enabled auto-merge (squash) March 18, 2022 18:05
@noahdietz noahdietz merged commit 5ad4de8 into main Mar 18, 2022
@noahdietz noahdietz deleted the rule-0191-invalid-characters branch March 18, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-191 File names must have valid characters
2 participants
@parthea @noahdietz