Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update gax to v1.17 #514

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

noahdietz
Copy link
Collaborator

Necessary for #513 which depends on the use of GAX's new API startAsyncCall.

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2022
@noahdietz noahdietz requested review from a team as code owners September 12, 2022 17:54
@gcf-merge-on-green gcf-merge-on-green bot merged commit 79a07f7 into googleapis:main Sep 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2022
dwsupplee pushed a commit to dwsupplee/gapic-generator-php that referenced this pull request Sep 26, 2022
Necessary for googleapis#513 which depends on the use of GAX's new API `startAsyncCall`.
dwsupplee added a commit that referenced this pull request Oct 6, 2022
* feat: introduce snippet gen support

* latest updates

* continued progress on DRYing up SnippetGenerator / code formatting

* small tweaks

* test out ShouldNotApplySemicolonInterface

* quick regen of tests

* remove getters to match other *Details based implemenations/minor refactorings

* change signature

* test regen

* revent name change in GapicClientExamplesGenerator

* refactor out nested ifs

* remove kms from prototests

* include line length fixer

* utilize line length formatter

* refactorings/cleanup

* refresh tests

* chore(deps): update dependency bazel_skylib to v1.3.0 (#512)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.2.1` -> `1.3.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-skylib</summary>

### [`v1.3.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.3.0)

[Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.2.1...1.3.0)

Release 1.3.0

**New Features**

-   Added `dicts.omit` and `dicts.pick` ([#&#8203;304](https://togithub.com/bazelbuild/bazel-skylib/issues/304))
-   Added `expand_template` rule ([#&#8203;330](https://togithub.com/bazelbuild/bazel-skylib/issues/330))
-   Added `subpackages` module ([#&#8203;348](https://togithub.com/bazelbuild/bazel-skylib/issues/348))
-   Added `copy_directory` rule ([#&#8203;366](https://togithub.com/bazelbuild/bazel-skylib/issues/366))
-   Added `bzlmod` support ([#&#8203;385](https://togithub.com/bazelbuild/bazel-skylib/issues/385))

**Incompatible Changes**

-   `native_binary` and `native_test` now use symlinks instead of copying, if the OS supports it ([#&#8203;340](https://togithub.com/bazelbuild/bazel-skylib/issues/340))
-   `native_binary` and `native_test` now build in target configuration instead of host configuration ([#&#8203;341](https://togithub.com/bazelbuild/bazel-skylib/issues/341))
-   `copy_file` no longer adds non-executables to `default_runfiles` ([#&#8203;326](https://togithub.com/bazelbuild/bazel-skylib/issues/326))

**Contributors**

Alex Eagle, Alexandre Rostovtsev, Barry McNamara, Derek Cormier, Fabian Meumertzheim, Geoffrey Martin-Noble, hchsiao, Kevin Kres, nickgooding, Vertexwahn, Vinh Tran

**WORKSPACE setup**

    load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
    http_archive(
        name = "bazel_skylib",
        urls = [
            "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.3.0/bazel-skylib-1.3.0.tar.gz",
            "https://github.com/bazelbuild/bazel-skylib/releases/download/1.3.0/bazel-skylib-1.3.0.tar.gz",
        ],
        sha256 = "74d544d96f4a5bb630d465ca8bbcfe231e3594e5aae57e1edbf17a6eb3ca2506",
    )
    load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
    bazel_skylib_workspace()

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-php).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODYuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4Ni4yIn0=-->

* chore(deps): update gax to v1.17 (#514)

Necessary for #513 which depends on the use of GAX's new API `startAsyncCall`.

* chore(deps): update rules_proto digest to ea52a32 (#511)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_proto | http_archive | digest | `dcf9e47` -> `ea52a32` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-php).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE5My4xIn0=-->

* prevent generation of empty docblocks

* Update src/Ast/AST.php

Co-authored-by: Brent Shaffer <[email protected]>

* help clarify when you would use a function vs a method

* remove arrayOf hack for param type

* add docblock to exampleValue

* add todo on fixer

* refactor printf helper

* sample line length 80 -> 100

* add comment regarding skip functionality

* append a message to resource field description

* update prototests

* modified approach for helper message

* refresh tests

* cleaner approach

* Update src/Generation/FieldDetails.php

Co-authored-by: Brent Shaffer <[email protected]>

* refresh tests

* append message using PhpDoc::preFormattedText instead of PhpDoc::text

* address regional endpoints/iam

* update call sample verbiage

* update goldens

* add generated notice to main sample docblock when no callSample exists

Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Noah Dietz <[email protected]>
Co-authored-by: Brent Shaffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants