Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change docker dep on common-protos to latest #243

Merged
merged 2 commits into from
Oct 29, 2019
Merged

chore: change docker dep on common-protos to latest #243

merged 2 commits into from
Oct 29, 2019

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Oct 29, 2019 •
edited
Loading

  • change api-common-protos docker dep to latest tag to pick up master changes
  • remove gapic-config-validator plugin from Docker image as it throws errors on things that are irrelevant to Go GAPICs

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
yihanzhen
yihanzhen approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit 86436c0 into googleapis:master Oct 29, 2019
@noahdietz noahdietz deleted the common-protos-latest branch October 29, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihanzhen yihanzhen yihanzhen approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahdietz @yihanzhen @googlebot