fix: handle type:object with format:google.protobuf.Any #138
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
force-pushed
the
gce-alpha-script
branch
from
0065cca to
794cdb5
Compare
vchudnov-g
changed the title
parthea
approved these changes
Dec 13, 2024
|
Added a PR description. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not handling the Discovery equivalent of proto
repeated Any, which shows up in Discovery docs as anarrayofobjectwithformat:google.protobuf.Any. This fixes that, and adds a test.Note that because we only allow
google.protobuf.Anywhen it's nested inside....error.details, the test case for this has more structure than other test cases for theformatfield.