feat: support Discovery "format" specifier for google.protobuf.{Value,ListValue,Struct} #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restores proto imports in the intended order, undoing the workaround in #108 due to protobufjs/protobuf.js#1954 now that the solution protobufjs/protobuf.js#1960 is implemented.
The schema "type" corresponding to each of these formats is as seen in the baseline file `compute.any-format.proto.baseline`. Googlers, also see cl/683528084 NOTE: that we continue to not handle `google.protobuf.Any`, whether it arises from a format specification with that value or from a `"type": "any"` with no "format" specified.
vchudnov-g
changed the title
The command I ran was:
gbazelisk run google_java_format_binary -- -r `pwd`/{src/main/java/com/google/cloud/discotoproto3converter/proto3/{DocumentToProtoConverter,Message},src/test/java/com/google/cloud/discotoproto3converter/DiscoToProto3ConverterAppTest}.java
noahdietz
approved these changes
Oct 10, 2024
src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java
Outdated
Show resolved
Hide resolved
The command I ran was:
gbazelisk run google_java_format_binary -- -r `pwd`/{src/main/java/com/google/cloud/discotoproto3converter/proto3/{DocumentToProtoConverter,Message},src/test/java/com/google/cloud/discotoproto3converter/DiscoToProto3ConverterAppTest}.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The converter will now recognize a
formatspecifier in certain schemas. Specifically, the following combinations are now recognized and result in a protobuf field whose type is the specifiedformat:"type""format"objectgoogle.protobuf.Structanygoogle.protobuf.Valuearraygoogle.protobuf.ListValueNote that, as was the case previously, other schemas with
"type" = "any"and any otherformat, including none, are not accepted unless they are in anerror.detailsfield. (Googlers, see also cl/683528084.)Incidentally, this PR also restores proto imports in the intended order, undoing the workaround in #108 due to protobufjs/protobuf.js#1954 now that the solution protobufjs/protobuf.js#1960 is implemented.