-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create/Pass commit date to commit for signing #485
base: main
Are you sure you want to change the base?
feat: Create/Pass commit date to commit for signing #485
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
@googleapis/github-automation can someone review my PR, this would unblock issues in release-please to sign commits. |
There is some open/related discussion in this issue: also /cc @chingor13 @SurferJeffAtGoogle |
@chingor13 @SurferJeffAtGoogle @bshaffer hey it would be cool to get some feedback whether this is something we can add to the package. As it is currently the commit signing capability is broken and does not work ... |
@sofisl @danieljbruce do you see any possibility to get this merged? |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #337 🦕