Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: should report failure if it failed to create a PR from quota #259

Closed
chingor13 opened this issue Aug 25, 2021 · 1 comment · Fixed by #329 or #333
Closed

action: should report failure if it failed to create a PR from quota #259

chingor13 opened this issue Aug 25, 2021 · 1 comment · Fixed by #329 or #333
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

chingor13 commented Aug 25, 2021 •
edited
Loading

If there are quota issues, the action silently fails.
@chingor13 chingor13 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 25, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Nov 23, 2021
@sofisl
Copy link
Contributor

sofisl commented Feb 18, 2022

This will go OOSLO soon.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 21, 2022
@chingor13 chingor13 mentioned this issue Feb 22, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 22, 2022
@chingor13
fix(cli,action): fix unawaited async call (#329)
3ef644c 
The unawaited async call causes the method to not throw, thus we always were returning a `0` exit status.

Fixes #259
@release-please release-please bot mentioned this issue Feb 22, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 22, 2022
@release-please
chore(main): release 2.1.3 (#333)
5d318ef 
🤖 I have created a release *beep* *boop*
---


### [2.1.3](v2.1.2...v2.1.3) (2022-02-22)


### Bug Fixes

* **cli,action:** fix unawaited async call ([#329](#329)) ([3ef644c](3ef644c)), closes [#259](#259)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@chingor13 @yoshi-automation @sofisl