Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: prebuild docker image to speed up action #141

Closed
chingor13 opened this issue Oct 8, 2020 · 1 comment · Fixed by #331 or #340
Closed

action: prebuild docker image to speed up action #141

chingor13 opened this issue Oct 8, 2020 · 1 comment · Fixed by #331 or #340
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Contributor

Currently the action takes longer than necessary because we build the action at execution time.
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 8, 2020
@chingor13
Copy link
Contributor Author

An alternative is to publish it as a javascript action

@chingor13 chingor13 mentioned this issue Apr 23, 2021
Closed
@chingor13 chingor13 mentioned this issue Feb 23, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 28, 2022
@chingor13
feat(action): build as an javascript action (#331)
257305d 
This switches the GitHub action to be a javascript action (from Docker). This is orders of magnitude faster to run -- no more docker build (or download) on every invocation.

The downside is that we must compile the dist file before each release. This is accomplished via a new workflow that runs on pushes to main that will open a new PR if there are changes to the dist output.

Fixes #141
@release-please release-please bot mentioned this issue Feb 28, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 28, 2022
@release-please
chore(main): release 2.2.0 (#340)
9222591 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](v2.1.4...v2.2.0) (2022-02-28)


### Features

* **action:** build as an javascript action ([#331](#331)) ([257305d](257305d)), closes [#141](#141)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@chingor13