Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rule for AIP-162 Delete Revision response message name #813

Merged
merged 2 commits into from
Jun 1, 2021
Merged

feat: Add rule for AIP-162 Delete Revision response message name #813

merged 2 commits into from
Jun 1, 2021

Conversation

apasel422
Copy link
Contributor

Fixes #721.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@apasel422 apasel422 marked this pull request as ready for review March 30, 2021 14:15
@apasel422 apasel422 requested a review from a team March 30, 2021 14:15
@apasel422
Copy link
Contributor Author

See my comment at #721 (comment) before approving this.

lukesneeringer
lukesneeringer suggested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assert that DeleteRevision should return the resource.

@apasel422
Copy link
Contributor Author

I assert that DeleteRevision should return the resource.

Always, or just for resources supporting soft-delete?

@lukesneeringer
Copy link
Contributor

Always.

@apasel422
Copy link
Contributor Author

In that case we need to update https://google.aip.dev/162#deleting-revisions first.

@apasel422 apasel422 mentioned this pull request Apr 27, 2021
Merged
@apasel422
Copy link
Contributor Author

In that case we need to update https://google.aip.dev/162#deleting-revisions first.

aip-dev/google.aip.dev#741

@apasel422
Copy link
Contributor Author

Ping.

@lukesneeringer lukesneeringer enabled auto-merge (squash) June 1, 2021 16:41
@lukesneeringer lukesneeringer merged commit f2d7d0f into googleapis:main Jun 1, 2021
@apasel422 apasel422 deleted the aip-162-delete-response branch June 1, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rules for AIP-162
2 participants
@apasel422 @lukesneeringer