Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rules for AIP-162 Commit request name behavior and resource reference #736

Merged
merged 3 commits into from
Feb 2, 2021
Merged

feat: Add rules for AIP-162 Commit request name behavior and resource reference #736

merged 3 commits into from
Feb 2, 2021

Conversation

apasel422
Copy link
Contributor

Part of #721.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2021
@apasel422 apasel422 marked this pull request as ready for review January 28, 2021 22:42
@apasel422 apasel422 requested a review from a team January 28, 2021 22:42
@apasel422
Copy link
Contributor Author

Is there anything left before this can be merged?

@lukesneeringer
Copy link
Contributor

Nope, safe to merge.

@lukesneeringer lukesneeringer merged commit 8240bda into googleapis:master Feb 2, 2021
@apasel422 apasel422 deleted the commit-request-name-annotations branch February 2, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apasel422 @lukesneeringer