Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract common lints into the util package to eliminate redundancy #687

Merged
merged 3 commits into from
Oct 15, 2020
Merged

refactor: Extract common lints into the util package to eliminate redundancy #687

merged 3 commits into from
Oct 15, 2020

Conversation

apasel422
Copy link
Contributor

No description provided.

@apasel422 apasel422 requested a review from a team October 14, 2020 20:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2020
lukesneeringer
lukesneeringer reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea that I had mused about doing. In some cases, we might be able to stop writing long-winded tests each time, too.

I do think we need common_lints_test.go, regardless of whether we eliminate individual tests.

rules/internal/utils/common_lints.go Show resolved Hide resolved
rules/internal/utils/common_lints.go Show resolved Hide resolved
@lukesneeringer lukesneeringer merged commit 9f67160 into googleapis:master Oct 15, 2020
@apasel422 apasel422 deleted the common branch October 15, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apasel422 @lukesneeringer