Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rule for required standard fields. #686

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Conversation

lukesneeringer
Copy link
Contributor

Fixes #659.

@lukesneeringer lukesneeringer requested a review from a team October 14, 2020 19:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2020
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with typos fixed

docs/rules/0148/declarative-friendly-fields.md Outdated Show resolved Hide resolved
docs/rules/0148/declarative-friendly-fields.md Outdated Show resolved Hide resolved
Co-authored-by: Noah Dietz <[email protected]>
@lukesneeringer lukesneeringer merged commit 3463d91 into master Oct 14, 2020
@lukesneeringer lukesneeringer deleted the issue-659 branch October 14, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-148: Declarative-friendly resources should include standard fields.
2 participants