Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add LRO rule for Update methods (declarative-friendly). #678

Merged
merged 4 commits into from
Oct 14, 2020
Merged

feat: Add LRO rule for Update methods (declarative-friendly). #678

merged 4 commits into from
Oct 14, 2020

Conversation

lukesneeringer
Copy link
Contributor

Fixes #662.

@lukesneeringer lukesneeringer requested a review from a team October 13, 2020 19:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
apasel422
apasel422 suggested changes Oct 14, 2020
View reviewed changes
docs/rules/0134/response-lro.md Outdated Show resolved Hide resolved
noahdietz
noahdietz approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the comment is fixed.

Luke Sneeringer and others added 2 commits October 14, 2020 09:57
@lukesneeringer lukesneeringer merged commit 7b7670c into master Oct 14, 2020
@lukesneeringer lukesneeringer deleted the issue-662 branch October 14, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apasel422 apasel422 apasel422 requested changes

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-134: Declarative-friendly Update should return LRO.
3 participants
@lukesneeringer @noahdietz @apasel422