Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-123): add validation of uppercase resource type #1074

Merged
merged 1 commit into from
Jan 30, 2023
Merged

feat(AIP-123): add validation of uppercase resource type #1074

merged 1 commit into from
Jan 30, 2023

Conversation

toumorokoshi
Copy link
Contributor

fixes #1066. See AIP-0123 for details.

@toumorokoshi toumorokoshi requested a review from a team as a code owner January 28, 2023 18:42
noahdietz
noahdietz reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but LGTM.

rules/aip0123/resource_type_name.go Outdated Show resolved Hide resolved
@noahdietz noahdietz added the automerge Summon MOG for automerging label Jan 30, 2023
@noahdietz noahdietz changed the title Adding validation of uppercase resource type feat(AIP-123): add validation of uppercase resource type Jan 30, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e0e1c61 into googleapis:main Jan 30, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-123: enforce UpperCamelCase of Resource Type names
2 participants
@toumorokoshi @noahdietz