feat: update to Go 1.18 #1014
Merged
feat: update to Go 1.18 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
Use of `strings.Title` which was deprecated in Go 1.18 is causing the `golint` target to fail for #1014. So this updates `strings.Title` to `cases.Title`.
|
Ready for review now. |
shwoodard
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to Go 1.18. An upgrade to Go 1.19 can be done later in conjunction with any gofmt changes introduced by it (there were minor formatting changes introduced in 1.19).
Go runtime version updates are shipped in minor releases per the README.md.