fix(ci): use go 1.18 in release job #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwoodard
approved these changes
Sep 8, 2022
|
cc @loeffel-io this is why the release job didn't work I think |
|
@noahdietz amazing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
releasejob fordarwin/arm64failed because thegcctoolchain fordarwin/arm64is not available on ubuntu by default. Apparently Go 1.16 added support for this compilation target, so I'm updating to Go 1.18 so as to 1. capture this change and 2. get the release job a little more up to date with modern Go version. I built the X-compiled binary locally with no issue.We should look at upping the version used across CI and in our
go.mod.